-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/azurerm: Adding azurerm_template_deployment
resource
#5758
Conversation
stack72
commented
Mar 21, 2016
|
||
name := d.Get("name").(string) | ||
resGroup := d.Get("resource_group_name").(string) | ||
deployment_mode := d.Get("deployment_mode").(string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go style nit, should be deploymentMode
azurerm_template_deployment
resourceazurerm_template_deployment
resource
log.Printf("[DEBUG] Waiting for Template Deployment (%s) to become available", name) | ||
stateConf := &resource.StateChangeConf{ | ||
Pending: []string{"Creating", "Updating", "Accepted", "Running"}, | ||
Target: []string{"Succeeded"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This casing feels brittle - I think we should make this all lower and have the RefreshFunc
return strings.ToLower()
of the status.
* `template_body` - (Optional) Specifies the JSON definition for the template. | ||
|
||
* `parameters` - (Optional) Specifies the name and value pairs that define the deployment parameters for the template. | ||
* `deploymnet_mode` - (Optional) Specifies the mode that is used to deploy resources. This value could be either `Incremental` or `Complete`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra newlines here might cause some funky markdown.
Two nits and a rebase to fix travis, this LGTM generally tho! |
Deployment resource
provider/azurerm: Adding `azurerm_template_deployment` resource
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |