Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datadog message, escalation_message, and query work with heredoc #5788

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Make datadog message, escalation_message, and query work with heredoc #5788

merged 1 commit into from
Mar 31, 2016

Conversation

multilinear
Copy link

I wrote this patch for my own company (Meteor), after running in to the issue covered by:
#5642
This patch uses the same fix suggested there, just applied to a couple other relevant fields where heredocs are desirable. Datadog didn't seem to strip "name" based on my testing.

Here's the output from a run of the acceptance tests (including the one I'm adding)

==> Checking that code complies with gofmt requirements...
/usr/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/datadog -v -timeout 120m
=== RUN TestProvider
--- PASS: TestProvider (0.00s)
=== RUN TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN TestAccDatadogMonitor_Basic
--- PASS: TestAccDatadogMonitor_Basic (97.48s)
=== RUN TestAccDatadogMonitor_Updated
--- PASS: TestAccDatadogMonitor_Updated (95.86s)
=== RUN TestAccDatadogMonitor_TrimWhitespace
--- PASS: TestAccDatadogMonitor_TrimWhitespace (68.40s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/datadog 261.738s

Sorry if I missed anything... first time contributing to terraform :).

@ojongerius
Copy link
Contributor

Nice one! LGTM

@billputer
Copy link

👍

@multilinear
Copy link
Author

Is there anything else I should do? Or are we just waiting for someone with magic bits to wander by and click merge?

@ojongerius
Copy link
Contributor

Yeah I think we are waiting for someone with commit rights to merge.

@jen20 merged the original provider and @stack72 labeled this PR. Anything we can do to get this merged?

@stack72
Copy link
Contributor

stack72 commented Mar 31, 2016

@multilinear thanks for the PR - this looks good to me :)

@ojongerius
Copy link
Contributor

Thanks @stack72

@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants