Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Fix Disabling DHCP on Subnets #6052

Merged
merged 1 commit into from
Apr 8, 2016

Conversation

jtopjian
Copy link
Contributor

@jtopjian jtopjian commented Apr 6, 2016

This commit fixes a bug where "false" was not correctly being passed to
the subnet creation and therefore enabling DHCP on all subnets.

This commit fixes a bug where "false" was not correctly being passed to
the subnet creation and therefore enabling DHCP on all subnets.
@jtopjian jtopjian merged commit 82c6afc into hashicorp:master Apr 8, 2016
jtopjian added a commit to jtopjian/terraform that referenced this pull request May 23, 2016
The openstack_networking_subnet_v2 resource was originally designed
to have DHCP disabled by default; however, a bug in the original
implementation caused DHCP to always be enabled and never be
disabled. This bug was fixed in hashicorp#6052.

Recent discussions have shown that users prefer if DHCP is enabled
by default. This commit implements makes the change.
cristicalin pushed a commit to cristicalin/terraform that referenced this pull request May 24, 2016
The openstack_networking_subnet_v2 resource was originally designed
to have DHCP disabled by default; however, a bug in the original
implementation caused DHCP to always be enabled and never be
disabled. This bug was fixed in hashicorp#6052.

Recent discussions have shown that users prefer if DHCP is enabled
by default. This commit implements makes the change.
@jtopjian jtopjian deleted the openstack-fix-disable-dhcp branch March 23, 2017 16:08
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant