Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/vsphere: Setting to skip customization #6355

Merged
merged 1 commit into from
Apr 29, 2016
Merged

provider/vsphere: Setting to skip customization #6355

merged 1 commit into from
Apr 29, 2016

Conversation

thetuxkeeper
Copy link
Contributor

We ran into the problem like described in #3562.
We use a template with empty disks. After deploying it will boot with PXE into CoreOS. The CoreOS will load an install cloud-init and install to disk. After a reboot it is ready for ansible.
Since "other Linux ..." is not supported for customization, terraform failed and I found no setting to change it.
With this new setting (skip_customization) you are able to skip the customization part.

if err != nil {
return err
if vm.skipCustomization {
log.Printf("[DEBUG]VM customization skipped")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing a space between [DEBUG] and the actual message.

@jen20
Copy link
Contributor

jen20 commented Apr 27, 2016

Hi @thetuxkeeper! This looks good - I've left a few minor nitpicks on the code. Once addressing these, could you squash your commits, and rebase onto master - and we can get this merged in time for the next release. Thanks for your work!

@thetuxkeeper
Copy link
Contributor Author

Hi @jen20
I fixed what you mentioned, rebased it onto master and squashed it into one commit.

@jen20 jen20 merged commit 9c85c2e into hashicorp:master Apr 29, 2016
@jen20
Copy link
Contributor

jen20 commented Apr 29, 2016

Thanks @thetuxkeeper! This is merged into master and will appear in the 0.6.16 release.

@thetuxkeeper
Copy link
Contributor Author

Thanks for reviewing and merging!

@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants