Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: refresh state on SQS Queue not found #6381

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Apr 27, 2016

Fixes #5578

When an SQS queue was deleted from the AWS Console, an error was thrown
to say that the Queue could not be found. This is now fixed to remove
the queue from the state on a specific not found exception

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSQSQueue' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSQSQueue -timeout 120m
=== RUN   TestAccAWSSQSQueue_basic
--- PASS: TestAccAWSSQSQueue_basic (20.52s)
=== RUN   TestAccAWSSQSQueue_redrivePolicy
--- PASS: TestAccAWSSQSQueue_redrivePolicy (18.80s)
=== RUN   TestAccAWSSQSQueue_Policybasic
--- PASS: TestAccAWSSQSQueue_Policybasic (24.17s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    63.516s

When an SQS queue was deleted from the AWS Console, an error was thrown
to say that the Queue could not be found. This is now fixed to remove
the queue from the state on a specific not found exception
@jen20
Copy link
Contributor

jen20 commented Apr 27, 2016

LGTM

@stack72 stack72 merged commit ee3d89a into master Apr 27, 2016
@stack72 stack72 deleted the b-sqs-refresh branch April 27, 2016 19:07
xsellier pushed a commit to xsellier/terraform that referenced this pull request May 17, 2016
When an SQS queue was deleted from the AWS Console, an error was thrown
to say that the Queue could not be found. This is now fixed to remove
the queue from the state on a specific not found exception
@bobbydeveaux
Copy link
Contributor

was about to fix this bug @stack72 - encountering this issue so checked out terraform and was going to fix! Decided to see if someone else had beat me to it, given I'm running 0.6.15..!

Time to upgrade! :)

Thanks for the fix.

@bobbydeveaux
Copy link
Contributor

Updated - perfect, thanks @stack72 !! :)

@stack72
Copy link
Contributor Author

stack72 commented Jun 23, 2016

👍

@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refresh does not destroy local resources it doesn't find
3 participants