provider/aws: Redshift Cluster not allowing 0 for automated_snapshot_retention_period #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, this wasn't noticed before as the tests for Redshift are not currently running nightly in Travis (there is a PR to fix that in place too) |
automated_snapshot_retention_period The default value for `automated_snapshot_retention_period` is 1. Therefore, it can be included in the `CreateClusterInput` without needing to check that it is set. This was actually stopping people from setting the value to 0 (disabling the snapshots) as there is an issue in `d.GetOk()` evaluating 0 for int
stack72
force-pushed
the
redshift-cluster-retention-default
branch
from
49418ff to
76b9581
Compare
|
LGTM. |
cristicalin
pushed a commit
to cristicalin/terraform
that referenced
this pull request
May 24, 2016
automated_snapshot_retention_period The default value for `automated_snapshot_retention_period` is 1. Therefore, it can be included in the `CreateClusterInput` without needing to check that it is set. This was actually stopping people from setting the value to 0 (disabling the snapshots) as there is an issue in `d.GetOk()` evaluating 0 for int
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for
automated_snapshot_retention_periodis 1.Therefore, it can be included in the
CreateClusterInputwithoutneeding to check that it is set.
This was actually stopping people from setting the value to 0 (disabling
the snapshots) as there is an issue in
d.GetOk()evaluating 0 for intAlso, documented that the Default is actually 1 here