Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix crash in ElastiCache param group #6687

Merged
merged 1 commit into from
May 17, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented May 16, 2016

Fixes crash reported in #6466

When you edit/save the defaults on the web UI (even without changing anything), you get a lot of parameters with default values added. One such parameter (notify-keyspace-events) is returned that has no value 😱

{
  DataType: "string",
  Description: "The keyspace events for Redis to notify Pub/Sub clients about. By default all notifications are disabled",
  IsModifiable: true,
  MinimumEngineVersion: "2.8.6",
  ParameterName: "notify-keyspace-events",
  Source: "user"
},

This PR only sets parameters locally if there is a value found

@jen20
Copy link
Contributor

jen20 commented May 17, 2016

LGTM!

@jen20 jen20 merged commit b08d741 into master May 17, 2016
@jen20 jen20 deleted the b-aws-elasticache-param-crash branch May 17, 2016 17:38
@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants