Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/google: Don't fail deleting disks that don't exist. #6689

Merged
merged 1 commit into from
May 20, 2016

Conversation

evandbrown
Copy link
Contributor

Addresses #5942

@evandbrown
Copy link
Contributor Author

Acceptance Test output:

$ make testacc TEST=./builtin/providers/google GOOGLE_PROJECT=evandbrown17 GOOGLE_REGION=us-central1 TESTARGS='-run=TestAccComputeInstance_disksWithA'                                                                               
==> Checking that code complies with gofmt requirements...
/home/evanbrown/dev/go-workspaces/terraform/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
2016/05/16 11:52:50 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeInstance_disksWithA -timeout 120m
=== RUN   TestAccComputeInstance_disksWithAutodelete
--- PASS: TestAccComputeInstance_disksWithAutodelete (90.59s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 90.695s

@jen20 jen20 merged commit 4b89e08 into hashicorp:master May 20, 2016
@jen20
Copy link
Contributor

jen20 commented May 20, 2016

LGTM - thanks @evandbrown!

@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants