Interpolate variable during Input and Validate

[jbardin]

fixes #5322

[jen20]

LGTM @jbardin! 🎉

[phinze]

What I'd do here is walk back to the PR / commit where this stanza was introduced and determine what the intent was just to double check that we're not reversing some prior decision.

The test suite should cover us, so the fact that everything is passing is probably enough, but I think for such a subtle area of the code base it's worth it to do extra due diligence.

Let me know what the git archeology turns up!

[jbardin]

This behavior was introduced in PR #432.
The latter test still exists, and the first test was removed via PR #2479.

[phinze]

We hashed this out in Slack, I submitted one extra test case I was concerned about. If you pull that into your branch this LGTM for merge! 🚢

[ddegoede]

@jbardin @phinze , should this be fixed in 0.7.0rc2? I think I am running into this issue, and if I replace the parameter with the actual contents of the module output, it works fine.

I am using the output of one module as input for another module, and then I get this error on the count:

* strconv.ParseInt: parsing "${length(split(\",\",var.vpc_id))}": invalid syntax

module "vpc" {
    source        = "../../_MODULES/VPC"
    globals       = "${var.globals}"
    cs            = "${var.cloud_build}"
    vpcs          = "${var.vpcs}"
    vpc_cidrs     = "${var.vpc_cidrs}"
    network_cidrs = "${var.network_cidrs}"
}

module "bastion_ip" {
    source        = "../../_MODULES/PUBLICIP"
    cs            = "${var.cloud_build}"
    vpc_id        = "${module.vpc.vpc_id}"
}

[jbardin]

@ddegoede, yes that patch should be in rc2. I wonder if this is somehow a different manifestation of the same problem.

Can you provide a standalone example that reproduces this in a new issue? Thanks!

[ddegoede]

@jbardin I created an new issue for my error with TF plan and modules

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.