provider/aws: Add iam_arn to aws_cloudfront_origin_access_identity #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the iam_arn attribute to aws_cloudfront_origin_access_identity, which computes the IAM ARN for a certain CloudFront origin access identity. This is necessary because S3 modifies the bucket policy if CanonicalUser is sent, causing spurious diffs with aws_s3_bucket resources.
vancluever
force-pushed
the
paybyphone_cloudfront_origin_access_identity_arn
branch
from
f2695f7 to
65824c7
Compare
|
Thanks! |
|
Thanks @catsby! |
|
reading this commit, I thought this would work... http://serverfault.com/q/837851/6852 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that when S3 normalizes a bucket policy it takes the
CanonicalUserprincipal and converts it to anAWSone, with an ARN like:This of course causes more of the spurious diffs that we all know and love ;)
So, I've added the
iam_arnto theaws_cloudfront_origin_access_identityresource and included some notes in the docs.