Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Retry finding route after creating it #7463

Merged
merged 1 commit into from
Jul 5, 2016
Merged

provider/aws: Retry finding route after creating it #7463

merged 1 commit into from
Jul 5, 2016

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Jul 1, 2016

The symptom is that a route "fails" to create, then every subsequent terraform apply fails with RouteAlreadyExists.

CreateRoute was succeeding but the very next DescribeRouteTables was not listing the new route.

The symptom is that a route "fails" to create, then every subsequent
`terraform apply` fails with RouteAlreadyExists.

CreateRoute was succeeding but the very next DescribeRouteTables
was not listing the new route.
@dtolnay dtolnay changed the title Retry finding route after creating it provider/aws: Retry finding route after creating it Jul 2, 2016
@catsby
Copy link
Contributor

catsby commented Jul 5, 2016

Looks great, thanks!
I pulled the branch locally and verified the acceptance tests still pass:

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
--- PASS: TestAccAWSRoute_basic (31.49s)
=== RUN   TestAccAWSRoute_changeCidr
--- PASS: TestAccAWSRoute_changeCidr (46.93s)
=== RUN   TestAccAWSRoute_noopdiff
--- PASS: TestAccAWSRoute_noopdiff (94.28s)
=== RUN   TestAccAWSRoute_doesNotCrashWithVPCEndpoint
--- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (33.82s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    206.535s
Test:

@catsby catsby merged commit 4ba75bd into hashicorp:master Jul 5, 2016
@dtolnay dtolnay deleted the route branch July 5, 2016 20:10
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants