Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "." in map keys #7654

Merged
merged 3 commits into from
Jul 15, 2016
Merged

Support "." in map keys #7654

merged 3 commits into from
Jul 15, 2016

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Jul 14, 2016

This pull request brings together various fixes for #2143 and #7130. The acceptance tests added by @sodre now pass:

make testacc TEST=./builtin/providers/triton TESTARGS="-run TestAccTritonMachine_metadata"
==> Checking that code complies with gofmt requirements...
/Users/James/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/07/14 12:39:07 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/triton -v -run TestAccTritonMachine_metadata -timeout 120m
=== RUN   TestAccTritonMachine_metadata
--- PASS: TestAccTritonMachine_metadata (140.83s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/triton 140.843s

cc @phinze

sodre and others added 3 commits June 11, 2016 22:19
- Tests for issue #2143.
- Fixed package names since Triton deprecated the g3-series.
- Must supply SDC_URL when invoking tests.

Test will fail on metadata_3 but not on _2 as discussed with
@jen20 on 11 June 2016.
@radeksimko
Copy link
Member

radeksimko commented Jul 15, 2016

Also fixes (hopefully) #3980

@phinze
Copy link
Contributor

phinze commented Jul 15, 2016

This LGTM - I'm going to follow it up with an extra unit test so we get coverage on this change on every commit.

@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants