config: Audit all interpolation functions for list/map behavior #7834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -487,11 +491,16 @@ func interpolationFuncDistinct() ast.Function { | |||
| var list []string | |||
|
|
|||
| if len(args) != 1 { | |||
| return nil, fmt.Errorf("distinct() excepts only one argument.") | |||
| return nil, fmt.Errorf("accepts only one argument.") | |||
There was a problem hiding this comment.
I learned that the caller prepends the function name automatically, so we were getting stutter in the resulting err messages.
There was a problem hiding this comment.
Confirmed error prints like this:
Errors:
* distinct: only works for flat lists, this list contains elements of type list in:
${distinct(list(list(","), list(",")))}
|
Minor nitpicks about error message consistency and a couple of typos in the docs, but otherwise LGTM! |
- `distinct()` - error on non-flat lists - `element()` - error on non-flat lists - `join()` - error on non-flat lists - `length()` - support maps - `lookup()` - error on non-flat maps - `values()` - error on non-flat maps
phinze
force-pushed
the
f-interp-funcs-list-map-audit
branch
from
3ca1de0
to
8803076
Compare
|
Okay addressed all the comments - will merge on green. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distinct()- error on non-flat listselement()- error on non-flat listsjoin()- error on non-flat listslength()- support mapslookup()- error on non-flat mapsvalues()- error on non-flat maps