provider/azure: add custom_data argument for azure_instance resource

[rjeczalik]

Hey!

This PR adds custom_data field to azure_instance resource. Azure SDK was updated to 3.2.0-beta to include custom_data support on the client side - Azure/azure-sdk-for-go#381.

Azure tests passed - results: https://gist.github.com/rjeczalik/bfb32e5aecb51be23d64149b48d8210e.

Please take a look.

[stack72]

Hi @rjeczalik

Thanks for the PR here. This LGTM! Thanks for including the test run as well :)

Paul

[sampcoug]

@stack72 @rjeczalik - I tried using "custom_data" argument to the " azurerm_virtual_machine_scale_set" resource. Terraform failed with the error below:

Error: azurerm_virtual_machine_scale_set.poc: : invalid or unknown key: custom_data

Is "custom_data" supported for this resource?

[rjeczalik]

@sampcoug custom_data is available for azure_instance resource, not the azurerm_virtual_machine_scale_set one.

[sampcoug]

@rjeczalik It worked for when I ran it. The os_profile supports it. So, for anyone trying to make it work for azurerm_virtual_machine_scale_set here is what I did:

  name                = "${var.env_prefix}${var.shortname}-scaleset"
  location            = "${var.region}"
  resource_group_name = "${var.resource_group_name}"
  upgrade_policy_mode = "Manual"
  zones               = [1,2,3]

  sku {
    name     = "Standard_D16s_v3"
    tier     = "Standard"
    capacity = 2
  }

  storage_profile_image_reference {
  	publisher = "CoreOS"
  	offer     = "CoreOS"
  	sku       = "Stable"
	  version   = "1911.4.0"
  }

  storage_profile_os_disk {
    name              = ""
    caching           = "ReadWrite"
    create_option     = "FromImage"
    managed_disk_type = "Standard_LRS"
  }

  storage_profile_data_disk {
    lun           = 0
    caching       = "ReadWrite"
    create_option = "Empty"
    disk_size_gb  = 100
  }

  os_profile {
    computer_name_prefix = "${var.env_prefix}xxx"
    admin_username       = "azureuser"
    custom_data = "${element(data.ct_config.service.*.rendered, count.index)}"
  }

  os_profile_linux_config {
    disable_password_authentication = true

    ssh_keys {
      path     = "/home/azureuser/.ssh/authorized_keys"
      key_data = "${file("xx")}"
    }
  }```

[rjeczalik]

@sampcoug Correct, indeed it has changed last time I used it - https://www.terraform.io/docs/providers/azurerm/r/virtual_machine_scale_set.html#custom_data.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.