Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Update ElasticTranscoder to allow empty notifications, removing notifications, etc #8207

Merged
merged 3 commits into from
Aug 16, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Aug 15, 2016

Allows users to supply empty ("") notifications for ElasticTranscoder, which amounts to unsetting them.

The current implementation doesn't allow you to remove any previously set ones, or omit any at all.

Adds acceptance test TestAccAWSElasticTranscoderPipeline_notifications which will fail on master.

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSElasticTranscoderPipeline_ -timeout 120m
=== RUN   TestAccAWSElasticTranscoderPipeline_basic
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (24.10s)
=== RUN   TestAccAWSElasticTranscoderPipeline_notifications
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (35.44s) <-- new 
=== RUN   TestAccAWSElasticTranscoderPipeline_withContentConfig
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (35.36s)
=== RUN   TestAccAWSElasticTranscoderPipeline_withPermissions
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (22.11s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    117.039s
Test:

Fixes #8163

@mitchellh
Copy link
Contributor

Great, LGTM

@catsby catsby merged commit 72a81ff into master Aug 16, 2016
@catsby catsby deleted the b-aws-etc-empty-notifications branch August 16, 2016 18:41
kwilczynski pushed a commit to kwilczynski/terraform that referenced this pull request Aug 18, 2016
…removing notifications, etc (hashicorp#8207)

* provider/aws: Add failing ETC + notifications test

* tidy up the docs some

* provider/aws: Update ElasticTranscoder to allow empty notifications, removing notifications, etc
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic Transcoder doesn't allow empty notifications.
2 participants