Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Refresh aws_route from state if aws_route_table not found #8443

Merged
merged 1 commit into from
Aug 26, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Aug 24, 2016

Fixes #5288
Fixes #8388

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRoute_'                                                  2 ↵
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/24 12:46:03 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
--- PASS: TestAccAWSRoute_basic (56.87s)
=== RUN   TestAccAWSRoute_changeCidr
--- PASS: TestAccAWSRoute_changeCidr (88.89s)
=== RUN   TestAccAWSRoute_noopdiff
--- PASS: TestAccAWSRoute_noopdiff (143.36s)
=== RUN   TestAccAWSRoute_doesNotCrashWithVPCEndpoint
--- PASS: TestAccAWSRoute_doesNotCrashWithVPCEndpoint (76.67s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    365.810s

@stack72 stack72 force-pushed the aws-route-refresh branch from 1609a6f to de6161f Compare August 24, 2016 11:55
@kwilczynski
Copy link
Contributor

@stack72 looks good! :shipit:

@mitchellh
Copy link
Contributor

LGTM!

@stack72 stack72 merged commit 6ea53e5 into master Aug 26, 2016
@stack72 stack72 deleted the aws-route-refresh branch August 26, 2016 06:50
richardbowden pushed a commit to richardbowden/terraform that referenced this pull request Aug 27, 2016
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route unable to destroy if RouteTable not present Deleting aws_route_internet_access in AWS breaks planning
3 participants