provider/aws: Add validation of Health Check target to aws_elb.

[kwilczynski]

This commit adds a simple validation of the target in the Health Check block in
order to reduce the number of issues related to the type, port and path values,
especially when the TCP and SSL type was used.

Signed-off-by: Krzysztof Wilczynski krzysztof.wilczynski@linux.com

[kwilczynski]

Resolves #8547.

[kwilczynski]

Tests are passing:

$  make test TEST=./builtin/providers/aws TESTARGS='-run=TestResourceAWSELB_ -v'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/31 14:57:05 Generated command/internal_plugin_list.go
TF_ACC= go test ./builtin/providers/aws -run=TestResourceAWSELB_ -v -timeout=30s -parallel=4
=== RUN   TestResourceAWSELB_validateElbNameCannotBeginWithHyphen
--- PASS: TestResourceAWSELB_validateElbNameCannotBeginWithHyphen (0.00s)
=== RUN   TestResourceAWSELB_validateElbNameCannotBeLongerThen32Characters
--- PASS: TestResourceAWSELB_validateElbNameCannotBeLongerThen32Characters (0.00s)
=== RUN   TestResourceAWSELB_validateElbNameCannotHaveSpecialCharacters
--- PASS: TestResourceAWSELB_validateElbNameCannotHaveSpecialCharacters (0.00s)
=== RUN   TestResourceAWSELB_validateElbNameCannotEndWithHyphen
--- PASS: TestResourceAWSELB_validateElbNameCannotEndWithHyphen (0.00s)
=== RUN   TestResourceAWSELB_validateHealthCheckTarget
--- PASS: TestResourceAWSELB_validateHealthCheckTarget (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    0.016s

[kwilczynski]

As per @stack72, I will add more validation here to cover more cases.

[kwilczynski]

Tests (more) passing:

 make test TEST=./builtin/providers/aws TESTARGS='-run=TestResourceAWSELB_validate -v'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/02 11:43:07 Generated command/internal_plugin_list.go
TF_ACC= go test ./builtin/providers/aws -run=TestResourceAWSELB_validate -v -timeout=30s -parallel=4
=== RUN   TestResourceAWSELB_validateElbNameCannotBeginWithHyphen
--- PASS: TestResourceAWSELB_validateElbNameCannotBeginWithHyphen (0.00s)
=== RUN   TestResourceAWSELB_validateElbNameCannotBeLongerThen32Characters
--- PASS: TestResourceAWSELB_validateElbNameCannotBeLongerThen32Characters (0.00s)
=== RUN   TestResourceAWSELB_validateElbNameCannotHaveSpecialCharacters
--- PASS: TestResourceAWSELB_validateElbNameCannotHaveSpecialCharacters (0.00s)
=== RUN   TestResourceAWSELB_validateElbNameCannotEndWithHyphen
--- PASS: TestResourceAWSELB_validateElbNameCannotEndWithHyphen (0.00s)
=== RUN   TestResourceAWSELB_validateAccessLogsInterval
--- PASS: TestResourceAWSELB_validateAccessLogsInterval (0.00s)
=== RUN   TestResourceAWSELB_validateListenerProtocol
--- PASS: TestResourceAWSELB_validateListenerProtocol (0.00s)
=== RUN   TestResourceAWSELB_validateHealthCheckTarget
--- PASS: TestResourceAWSELB_validateHealthCheckTarget (0.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    0.016s

[stack72]

Hi @kwilczynski

This LGTM! Tests are green :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSELB_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/04 00:03:07 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSELB_ -timeout 120m
=== RUN   TestAccAWSELB_importBasic
--- PASS: TestAccAWSELB_importBasic (34.15s)
=== RUN   TestAccAWSELB_basic
--- PASS: TestAccAWSELB_basic (33.02s)
=== RUN   TestAccAWSELB_fullCharacterRange
--- PASS: TestAccAWSELB_fullCharacterRange (32.23s)
=== RUN   TestAccAWSELB_AccessLogs
--- PASS: TestAccAWSELB_AccessLogs (103.40s)
=== RUN   TestAccAWSELB_generatedName
--- PASS: TestAccAWSELB_generatedName (29.56s)
=== RUN   TestAccAWSELB_availabilityZones
--- PASS: TestAccAWSELB_availabilityZones (55.03s)
=== RUN   TestAccAWSELB_tags
--- PASS: TestAccAWSELB_tags (58.03s)
=== RUN   TestAccAWSELB_iam_server_cert
--- PASS: TestAccAWSELB_iam_server_cert (45.02s)
=== RUN   TestAccAWSELB_InstanceAttaching
--- PASS: TestAccAWSELB_InstanceAttaching (177.16s)
=== RUN   TestAccAWSELB_HealthCheck
--- PASS: TestAccAWSELB_HealthCheck (49.07s)
=== RUN   TestAccAWSELB_Timeout
--- PASS: TestAccAWSELB_Timeout (32.71s)
=== RUN   TestAccAWSELB_ConnectionDraining
--- PASS: TestAccAWSELB_ConnectionDraining (29.71s)
=== RUN   TestAccAWSELB_SecurityGroups
--- PASS: TestAccAWSELB_SecurityGroups (65.13s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    744.231s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.