Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add aws_sns_topic_policy #8654

Merged
merged 1 commit into from
Sep 4, 2016

Conversation

radeksimko
Copy link
Member

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSSNSTopicPolicy'
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSSNSTopicPolicy -timeout 120m
=== RUN   TestAccAWSSNSTopicPolicy_basic
--- PASS: TestAccAWSSNSTopicPolicy_basic (25.03s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    25.055s

"policy": {
Type: schema.TypeString,
Required: true,
DiffSuppressFunc: suppressEquivalentAwsPolicyDiffs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@stack72
Copy link
Contributor

stack72 commented Sep 4, 2016

@radeksimko this is a great addition! Tests are green :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSNSTopicPolicy_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/04 20:45:27 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSNSTopicPolicy_ -timeout 120m
=== RUN   TestAccAWSSNSTopicPolicy_basic
--- PASS: TestAccAWSSNSTopicPolicy_basic (61.15s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    61.168s

@stack72 stack72 merged commit 04c16b8 into hashicorp:master Sep 4, 2016
@radeksimko radeksimko deleted the f-aws-sns-policy branch September 4, 2016 18:52
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants