-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Expose ARN suffix on ALB #8833
Conversation
3ff2f4f
to
7de0f0d
Compare
Functionally this looks good, I'm just thinking that the suffix may be useful for something else in the future - so I'm not sure I'd make the assumption it's only useful for CloudWatch. TL;DR I'd simply call it |
That was the other name I was considering - happy to change it. I'll push a new commit up here. |
When creating a CloudWatch Metric for an Application Load Balancer it is neccessary to use the suffix of the ARN as the reference to the load balancer. This commit exposes that as an attribute on the `aws_alb` resource to prevent the need to use regular expression substitution to make the reference. Fixes #8808.
@radeksimko I've changed the name and pushed a fix. |
LGTM |
Thanks so much! |
When creating a CloudWatch Metric for an Application Load Balancer it is neccessary to use the suffix of the ARN as the reference to the load balancer. This commit exposes that as an attribute on the `aws_alb` resource to prevent the need to use regular expression substitution to make the reference. Fixes hashicorp#8808.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
When creating a CloudWatch Metric for an Application Load Balancer it is neccessary to use the suffix of the ARN as the reference to the load balancer. This commit exposes that as an attribute on the
aws_alb
resource to prevent the need to use regular expression substitution to make the reference.Fixes #8808.