Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Expose ARN suffix on ALB #8833

Merged
merged 1 commit into from
Sep 14, 2016
Merged

provider/aws: Expose ARN suffix on ALB #8833

merged 1 commit into from
Sep 14, 2016

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Sep 14, 2016

When creating a CloudWatch Metric for an Application Load Balancer it is neccessary to use the suffix of the ARN as the reference to the load balancer. This commit exposes that as an attribute on the aws_alb resource to prevent the need to use regular expression substitution to make the reference.

Fixes #8808.

@jen20 jen20 force-pushed the f-alb-suffix branch 2 times, most recently from 3ff2f4f to 7de0f0d Compare September 14, 2016 08:52
@radeksimko
Copy link
Member

radeksimko commented Sep 14, 2016

Functionally this looks good, I'm just thinking that the suffix may be useful for something else in the future - so I'm not sure I'd make the assumption it's only useful for CloudWatch.

TL;DR I'd simply call it arn_suffix instead of cloudwatch_ref and keep the note in docs about the use case (CloudWatch).

@jen20
Copy link
Contributor Author

jen20 commented Sep 14, 2016

That was the other name I was considering - happy to change it. I'll push a new commit up here.

When creating a CloudWatch Metric for an Application Load Balancer it is
neccessary to use the suffix of the ARN as the reference to the load
balancer. This commit exposes that as an attribute on the `aws_alb`
resource to prevent the need to use regular expression substitution to
make the reference.

Fixes #8808.
@jen20
Copy link
Contributor Author

jen20 commented Sep 14, 2016

@radeksimko I've changed the name and pushed a fix.

@jen20 jen20 changed the title provider/aws: Expose CloudWatch Metrics ref on ALB provider/aws: Expose ARN suffix on ALB Sep 14, 2016
@catsby
Copy link
Contributor

catsby commented Sep 14, 2016

LGTM

@radeksimko radeksimko merged commit 9d51ebd into master Sep 14, 2016
@radeksimko radeksimko deleted the f-alb-suffix branch September 14, 2016 14:50
@sj26
Copy link

sj26 commented Sep 14, 2016

Thanks so much!

sharmaansh21 pushed a commit to sharmaansh21/terraform that referenced this pull request Sep 15, 2016
When creating a CloudWatch Metric for an Application Load Balancer it is
neccessary to use the suffix of the ARN as the reference to the load
balancer. This commit exposes that as an attribute on the `aws_alb`
resource to prevent the need to use regular expression substitution to
make the reference.

Fixes hashicorp#8808.
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ease using AWS ALBs in CloudWatch metrics
4 participants