Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws - Add update support for search_string in aws_cloudwatch_metric_alarm #9230

Merged
merged 1 commit into from
Oct 5, 2016
Merged

provider/aws - Add update support for search_string in aws_cloudwatch_metric_alarm #9230

merged 1 commit into from
Oct 5, 2016

Conversation

heimweh
Copy link
Contributor

@heimweh heimweh commented Oct 5, 2016

When updating a search_string using the "aws_route53_health_check" resource it doesn't actually update the search_string.

This PR aims to solve that issue, also added a separate test case for this.

Done by: @comebackoneyear & @heimweh

@heimweh heimweh changed the title Add update support for search_string provider/aws - Add update support for search_string in aws_cloudwatch_metric_alarm Oct 5, 2016
@heimweh
Copy link
Contributor Author

heimweh commented Oct 5, 2016

Tests passing

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRoute53HealthCheck'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/05 13:19:04 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRoute53HealthCheck -timeout 120m
=== RUN   TestAccAWSRoute53HealthCheck_importBasic
--- PASS: TestAccAWSRoute53HealthCheck_importBasic (24.80s)
=== RUN   TestAccAWSRoute53HealthCheck_basic
64710b57-3a07-4c9c-a918-69838e5653d364710b57-3a07-4c9c-a918-69838e5653d3
--- PASS: TestAccAWSRoute53HealthCheck_basic (38.33s)
=== RUN   TestAccAWSRoute53HealthCheck_withSearchString
cefd308a-27c6-4ef0-8363-c4d6288e08b3cefd308a-27c6-4ef0-8363-c4d6288e08b3
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (39.91s)
=== RUN   TestAccAWSRoute53HealthCheck_withChildHealthChecks
964499e0-310f-40d8-bab1-59529fca5508--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (27.75s)
=== RUN   TestAccAWSRoute53HealthCheck_IpConfig
05be8c51-a33e-4417-9d0e-aac72387f393
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (23.57s)
=== RUN   TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck
88395860-2e62-425a-8418-db74a4731e02--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (28.23s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    182.610s

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@catsby catsby merged commit e2c74fc into hashicorp:master Oct 5, 2016
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants