Do not return a root device for instance store backed AMIs.

[tomwilkie]

Fixes #8732

@tpounds opening the PR for you - I just hit this myself.

[stack72]

Hi @tomwilkie

Any chance we could get a test in place to show this works as expected?

:)

P.

[tomwilkie]

@stack72 I didn't write this, its not my branch. I just found the tested the fix locally, so I thought it would be worth a PR.

[tpounds]

@stack72, @tomwilkie Apologies for the delay. I pushed this branch to quickly fix the issue on our end but didn't spend any time to add an acceptance test. I've added it now. Please ping me if there is something else I should address

[tpounds]

@stack72 Is this fix ok to merge? Several people are waiting on it.

cc @tomwilkie @omribahumi @jbussdieker @michael-henderson

[stack72]

Hey @tomwilkie / @tpounds

Thanks for the team work here on this :) LGTM!

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSInstance_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/01 15:06:54 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInstance_ -timeout 120m
=== RUN   TestAccAWSInstance_importBasic
--- PASS: TestAccAWSInstance_importBasic (108.41s)
=== RUN   TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_basic (158.61s)
=== RUN   TestAccAWSInstance_GP2IopsDevice
--- PASS: TestAccAWSInstance_GP2IopsDevice (85.35s)
=== RUN   TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_blockDevices (127.45s)
=== RUN   TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_rootInstanceStore (78.17s)
=== RUN   TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_sourceDestCheck (214.47s)
=== RUN   TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_disableApiTermination (183.05s)
=== RUN   TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_vpc (129.07s)
=== RUN   TestAccAWSInstance_multipleRegions
--- PASS: TestAccAWSInstance_multipleRegions (129.45s)
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (143.42s)
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (143.38s)
=== RUN   TestAccAWSInstance_tags
--- PASS: TestAccAWSInstance_tags (124.90s)
=== RUN   TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_privateIP (239.87s)
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (250.50s)
=== RUN   TestAccAWSInstance_keyPairCheck
--- PASS: TestAccAWSInstance_keyPairCheck (88.48s)
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (120.83s)
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (362.08s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	2687.512s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.