Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: Add support for using source_disk to google_compute_image #9614

Merged
merged 1 commit into from
Nov 1, 2016
Merged

provider/google: Add support for using source_disk to google_compute_image #9614

merged 1 commit into from
Nov 1, 2016

Conversation

cblecker
Copy link
Contributor

Fixes #9262.

Allows you to use an existing disk resource to then funnel back to an image resource.

$ make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeImage...'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/26 01:09:22 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeImage... -timeout 120m
=== RUN   TestAccComputeImage_basic
--- PASS: TestAccComputeImage_basic (79.13s)
=== RUN   TestAccComputeImage_basedondisk
--- PASS: TestAccComputeImage_basedondisk (104.79s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 183.926s

@cblecker cblecker changed the title Add support for using source_disk to google_compute_image provider/google: Add support for using source_disk to google_compute_image Oct 26, 2016
@stack72
Copy link
Contributor

stack72 commented Nov 1, 2016

LGTM! Thanks :)

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeImage'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/01 10:29:19 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeImage -timeout 120m
=== RUN   TestAccComputeImage_basic
--- PASS: TestAccComputeImage_basic (70.52s)
=== RUN   TestAccComputeImage_basedondisk
--- PASS: TestAccComputeImage_basedondisk (82.31s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 152.850s

@stack72 stack72 merged commit ca8cd4b into hashicorp:master Nov 1, 2016
@cblecker cblecker deleted the f-source-disk branch November 1, 2016 16:52
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provider/google: include option to use source_disk with google_compute_image
2 participants