Added AWS Resource WAF ByteMatchSet

[sharmaansh21]

➜  terraform git:(resource-aws-waf-byte-match-set) ✗ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSWafByteMatchSet_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/28 14:54:27 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSWafByteMatchSet_ -timeout 120m
=== RUN   TestAccAWSWafByteMatchSet_basic
--- PASS: TestAccAWSWafByteMatchSet_basic (65.40s)
=== RUN   TestAccAWSWafByteMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafByteMatchSet_changeNameForceNew (117.77s)
=== RUN   TestAccAWSWafByteMatchSet_disappears
--- PASS: TestAccAWSWafByteMatchSet_disappears (61.17s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    249.671s

[sharmaansh21]

/cc @stack72

[stack72]

Hi @optimisticanshul

Just left 1 small comment inline - if you can say that's fine then LGTM :)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSWafByteMatchSet_'                                       ✹
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/10/28 11:50:40 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSWafByteMatchSet_ -timeout 120m
=== RUN   TestAccAWSWafByteMatchSet_basic
--- PASS: TestAccAWSWafByteMatchSet_basic (30.13s)
=== RUN   TestAccAWSWafByteMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafByteMatchSet_changeNameForceNew (57.46s)
=== RUN   TestAccAWSWafByteMatchSet_disappears
--- PASS: TestAccAWSWafByteMatchSet_disappears (28.27s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    115.884s

[stack72]

Is there every a chance that resp.ByteMatchSet will be nil?

[sharmaansh21]

Nope.

[stack72]

Thanks :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.