provider/openstack: LoadBalancer v2 VIP Port ID #9727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtopjian
force-pushed
the
openstack-lbaasv2-vipportid
branch
from
e60165b
to
5bfa42f
Compare
stack72
reviewed
Oct 31, 2016
| @@ -57,6 +57,12 @@ func resourceLoadBalancerV2() *schema.Resource { | |||
| ForceNew: true, | |||
| }, | |||
|
|
|||
| "vip_port_id": &schema.Schema{ | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
There was a problem hiding this comment.
IF this is exported only, then we shouldn't have the Optional: true - this allows the user to set it. But we never use the value
There was a problem hiding this comment.
Thanks, Paul. I was going to double-check this on Slack :)
So just remove the Optional?
This commit adds vip_port_id as an exported attribute to the lb_loadbalancer_v2 resource.
jtopjian
force-pushed
the
openstack-lbaasv2-vipportid
branch
from
5bfa42f
to
e75d414
Compare
|
LGTM! Thanks for the work @jtopjian :) |
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
This commit adds vip_port_id as an exported attribute to the lb_loadbalancer_v2 resource.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds vip_port_id as an exported attribute to the
lb_loadbalancer_v2 resource.
Fixes #7542
/cc @dkalleg