rsync behaves badly with '*' char in rsync__exclude (seems only on windows)

[clementbethuys]

Hi,

I'have been hit by a bug (seems only on windows)

If we use in Vagrantfile
rsync__exclude: ['folder_name/*']
and 'folder_name' exist in Vagrant directory (which is not the synced directory)

Rsync will mess up.
I believe the 'folder_name/*' string is interpreted by the windows shell.

I created a minimal github repo to reproduce the case https://github.com/clementbethuys/vagrant_bug.git

A basic workaround is to use instead

rsync__exclude: ['folder_name/']
and then create the folder on the VM (if necessary)

Versions I use

Vagrant 1.6.3 (and at least 1.5.2)
rsync version 3.0.9 (cygwin)
shell, cygwin or git shell

[mitchellh]

Vagrant doesn't subprocess rsync into a shell, it uses CreateProcess directly (avoiding any shell expansion). This sounds like maybe rsync is expanding it improperly. I've seen this happen when rsync is itself a shell script passing the arguments through. Can you verify this?

I was unable to repro your issue and haven't heard anyone else with it. Closing until I can repro.