Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in 2.x release #395

Closed
ppanyukov opened this issue Jun 16, 2020 · 11 comments
Closed

Issues in 2.x release #395

ppanyukov opened this issue Jun 16, 2020 · 11 comments

Comments

@ppanyukov
Copy link

Everything was working fine. Now the extension auto-updated and nothing works. Who make this assumption that the root of my directory is terraform thing? Why can't I disable this "language server"? Formatter doesn't work either. Can't revert to previous working version either.

Total disaster.

@oliversalzburg
Copy link

See #366 (comment) for a possible workaround.

@sorin-costea
Copy link

I'm a bit confused, what does this 2.0.1 version actually DO, I mean part from installing without errors?

@oliversalzburg
Copy link

@sorin-costea I believe one of the important changes is the improved 0.12 language syntax support.

In the previous version, my entire project file tree was marked red, because VS Code thought every single file had syntax errors. I don't have that anymore, which is nice.

@sorin-costea
Copy link

@oliversalzburg you're right, there are no syntax errors marked anymore - because it does nothing 😊 No linting is happening at all just a bit of coloring, and you'll see your errors only when terraform plan...

@FernandoMiguel
Copy link

@sorin-costea I believe one of the important changes is the improved 0.12 language syntax support.

In the previous version, my entire project file tree was marked red, because VS Code thought every single file had syntax errors. I don't have that anymore, which is nice.

@oliversalzburg
the never officially released v1.4 did all that with 0.12 , no issues.
but since it was stuck in a thread on github , not everyone knew about it.

@oliversalzburg
Copy link

@oliversalzburg you're right, there are no syntax errors marked anymore - because it does nothing 😊 No linting is happening at all just a bit of coloring, and you'll see your errors only when terraform plan...

Yeah, that surely is disappointing. For me the root cause was that I have multiple Terraform projects in my workspace and the extension recognized that as an uninitialized workspace. The comment I quoted above helped me to work around the issue. Now I'm at least able to work again.

There was actually an RC of the 2.0 version of this extension, which I neglected to test :( Now I'm just hoping for quick improvements. Good luck :)

@paultyng paultyng changed the title Thank for completely breaking this since 2.x release Issues in 2.x release Jun 16, 2020
@sorin-costea
Copy link

@FernandoMiguel I uninstalled 2.0.1 and installed 1.4 from the download file and it still does no linting. Could it be something to be configured on MY side? I never did anything for the 1.3.x they just worked fine (except 0.12 syntax) after install...

@paultyng
Copy link
Contributor

@ppanyukov I understand the frustration, we are working to address the outstanding issues, all that said there is no need for the sarcasm and doesn't help the situation or get it fixed any faster.

The downgrading issue is still an upstream VS Code issue. It was just (very) unfortunate timing that they had that bug introduced when we shipped our new version. We never intended that to stop working which is why our release notes and launch blog post both included the standard downgrade instructions.

@FernandoMiguel
Copy link

@FernandoMiguel I uninstalled 2.0.1 and installed 1.4 from the download file and it still does no linting. Could it be something to be configured on MY side? I never did anything for the 1.3.x they just worked fine (except 0.12 syntax) after install...

you need tflint (app and vscode ext https://github.com/terraform-linters/tflint )
I opened ticket #337 for that

@paultyng
Copy link
Contributor

paultyng commented Jun 16, 2020

I don't think there is anything new raised in this issue, the existing ones probably cover it:

@ghost
Copy link

ghost commented Jul 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants