Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit issue should work with IssueNumber instead of Id Issue #428

Closed
vrom911 opened this issue Feb 9, 2020 · 1 comment · Fixed by #429
Closed

Edit issue should work with IssueNumber instead of Id Issue #428

vrom911 opened this issue Feb 9, 2020 · 1 comment · Fixed by #429
Labels
bug pr welcome

Comments

@vrom911
Copy link
Contributor

vrom911 commented Feb 9, 2020

As per the specifications, the endpoint should contain the issue number, not the issue ID.

Currently, editIssueR has the following type:

editIssueR :: Name Owner -> Name Repo -> Id Issue -> EditIssue -> Request 'RW Issue

I propose to change it to:

editIssueR :: Name Owner -> Name Repo -> IssueNumber -> EditIssue -> Request 'RW Issue
@vrom911 vrom911 mentioned this issue Feb 9, 2020
Merged
@phadej
Copy link
Contributor

phadej commented Feb 10, 2020

Thanks for catching this. PR would be nice.

@vrom911 vrom911 mentioned this issue Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pr welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use IssueNumber in editIssueR and issueR
2 participants
@phadej @vrom911