Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for 9.6.4 #3939

Closed
michaelpj opened this issue Jan 10, 2024 · 7 comments
Closed

Release for 9.6.4 #3939

michaelpj opened this issue Jan 10, 2024 · 7 comments

Comments

@michaelpj
Copy link
Collaborator

This is a release-tracking ticket.

@michaelpj
Copy link
Collaborator Author

It would be nice to get #3937 done but not a blocker, depends on when @soulomoon gets to it.

@fendor
Copy link
Collaborator

fendor commented Jan 10, 2024

hls-cabal-plugin needs to honour globalOn configuration. Currently, diagnostics are produced, even if the plugin is turned off.

@wz1000
Copy link
Collaborator

wz1000 commented Jan 10, 2024

I have a fix for #3542 failures with 9.8 in hiedb.

@soulomoon
Copy link
Collaborator

soulomoon commented Jan 10, 2024

It would be nice to get #3937 done but not a blocker, depends on when @soulomoon gets to it.

Sure, I've opened a pull request for this in #3940.

@benz0li
Copy link

benz0li commented Jan 11, 2024

Building of HLS 2.5.0.0 currently fails using GHC 9.6.4:


My environment

Which OS do you use? Alpine Linux 3.19.0

Which version of GHC do you use and how did you install it? 9.6.4
👉 Docker image glcr.b-data.ch/ghc/ghc-musl:9.6.4 (https://github.com/benz0li/ghc-musl)

Steps to reproduce

On a host with docker installed

docker run --rm -ti glcr.b-data.ch/ghc/ghc-musl:9.6.4 bash

Inside the container

export HLS_VERSION=2.5.0.0 \
  && apk add --no-cache patchelf findutils \
  && cd /tmp \
  && curl -sSL "https://github.com/haskell/haskell-language-server/archive/refs/tags/$HLS_VERSION.tar.gz" \
    -o "haskell-language-server-$HLS_VERSION.tar.gz" \
  && tar -xzf "haskell-language-server-$HLS_VERSION.tar.gz" \
  && cd "haskell-language-server-$HLS_VERSION" \
  && . .github/scripts/env.sh \
  && . .github/scripts/common.sh \
  && sed -i.bak -e '/DELETE MARKER FOR CI/,/END DELETE/d' cabal.project \
  && GHCS="$GHC_VERSION" \
  && export GHCS \
  && ARTIFACT="$(uname -m)-linux-alpine" \
  && export ARTIFACT \
  && cabal update \
  && emake hls-ghc \
  && emake bindist \
  && strip "out/bindist/$ARTIFACT/haskell-language-server-$HLS_VERSION/lib/$GHC_VERSION"/*.so \
  && emake bindist-tar

Logfile

logfile.txt

@wz1000
Copy link
Collaborator

wz1000 commented Jan 11, 2024

@benz0li see #3929

@wz1000
Copy link
Collaborator

wz1000 commented Jan 20, 2024

This was released.

@wz1000 wz1000 closed this as completed Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants