Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow preventing events from firing when making mutations #3508

Open
pnappa opened this issue Dec 10, 2019 · 0 comments · May be fixed by sumodgeorge/graphql-engine#30, Allymahmoud/graphql-engine#386 or ptakpatryk/graphql-engine#27
Labels
a/eventing/data-triggers k/ideas Discuss new ideas / pre-proposals / roadmap

Comments

@pnappa
Copy link

pnappa commented Dec 10, 2019

Hi,

We recently had an embarrassing incident where one of our triggers were accidentally re-entrant, e.g. the trigger was invoked when editing a table, and on update of that table the same trigger was invoked again, ad infinitum.

This was completely accidental, and in part caused by a developer error in enabling this trigger when it shouldn't have been. Column based selective-updates kind of help, but in no-way help to solidly prevent this kind of scenario happening again. What we're looking for is a way to indicate from an admin context (this is important, as if unauthorised users are allowed to do this, the app's internal state may be left inconsistent), that a trigger that is on a table shouldn't be able to be invoked.

The team was helpful on the Discord, and pointed me to this issue: #1241 , but it isn't quite what I'm talking about.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/eventing/data-triggers k/ideas Discuss new ideas / pre-proposals / roadmap
Projects
None yet
3 participants