Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hasura migrate create --from-server loses manual SQL migrations which breaks enum tables #4222

Open
maxcan opened this issue Mar 28, 2020 · 5 comments
Labels
c/cli Related to CLI

Comments

@maxcan
Copy link

maxcan commented Mar 28, 2020

If you use that approach to squash migrations, you lose any manual INSERT INTO SQL migrations that you've run.

The main problem with this is that if you have any enum tables, they new migrations will break since enum tables must have at least one row.

At a minimum, this should be noted in the docs (happy to put in some copy if you want) but ideally the --from-server option should have an option to include manual SQL insertion migrations or a big flashing warning when you try to run it on a DB with enum tables.

This is on GQL Engine 1.1 but has been an issue since enum tables were released.

@tirumaraiselvan tirumaraiselvan added the support/needs-triage Needs to be triaged so that we have enough information to add this to our backlog label Mar 30, 2020
@shahidhk shahidhk added duplicate This issue or pull request already exists and removed support/needs-triage Needs to be triaged so that we have enough information to add this to our backlog labels Mar 30, 2020
@shahidhk
Copy link
Member

@maxcan We're aware of the issue and some discussions are going on at #2817

Closing this issue in favour of the other one.

@tirumaraiselvan tirumaraiselvan added c/cli Related to CLI and removed duplicate This issue or pull request already exists labels Oct 12, 2020
@tirumaraiselvan
Copy link
Contributor

#2817 is closed with a console side solution. Hence, reopening this for the cli side issue.

@maxcan
Copy link
Author

maxcan commented Oct 12, 2020

@tirumaraiselvan thanks for the update. looking forward to 1.4!

@seanonthenet
Copy link

Is this fixed in 2.0.0 ?

@seanonthenet
Copy link

seanonthenet commented Apr 12, 2021

Please can this be added to 2.0.0 milestone. Still not supported. 🙏

@scriptonist scriptonist added the support/needs-triage Needs to be triaged so that we have enough information to add this to our backlog label Oct 1, 2021
@rikinsk rikinsk removed the support/needs-triage Needs to be triaged so that we have enough information to add this to our backlog label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/cli Related to CLI
Projects
None yet
Development

No branches or pull requests

7 participants
@maxcan @shahidhk @seanonthenet @scriptonist @tirumaraiselvan @rikinsk and others