Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when creating cron with '/' in name #5935

Closed
rolivegab opened this issue Oct 6, 2020 · 2 comments
Closed

Bug when creating cron with '/' in name #5935

rolivegab opened this issue Oct 6, 2020 · 2 comments
Assignees
Labels
c/console Related to console k/bug Something isn't working

Comments

@rolivegab
Copy link

rolivegab commented Oct 6, 2020

Cron is created succesfully:
image

But when i click on it, this happens:
image

[EDIT]

Just to being more informative, accessing url at: http://localhost:9695/console/events/cron/cron%2Fclear-confirmation-codes/modify manually works.

@beerose beerose added c/console Related to console k/bug Something isn't working labels Oct 6, 2020
@kentaro84207
Copy link
Contributor

kentaro84207 commented Oct 7, 2020

May I work on this issue?

@beerose
Copy link
Contributor

beerose commented Oct 7, 2020

Sure @kentaro84207!

I guess we need to use encodeURIComponent function for cron trigger name in the path, as we do for example here: https://github.com/hasura/graphql-engine/blob/master/console/src/components/Common/utils/routesUtils.js#L7.

@beerose beerose linked a pull request Oct 19, 2020 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console Related to console k/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants