Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PausableUpgradeable is not initialized #2

Open
hats-bug-reporter bot opened this issue Nov 11, 2024 · 1 comment
Open

PausableUpgradeable is not initialized #2

hats-bug-reporter bot opened this issue Nov 11, 2024 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@hats-bug-reporter
Copy link

Github username: @rilwan99
Twitter username: Ril11111
Submission hash (on-chain): 0x6f9ae2bfc42be8f59f721169bec15459b8d33eee4458af6c452049d1b504f29a
Severity: high

Description:
Description
Router.sol inherits from PausableUpgradeable.sol, however fails to initialie it via __Pausable_init(). This oversight can lead to the PausableUpgradeable contract not being properly initialized, which might cause unexpected behavior when attempting to use pause-related functionality.

Attack Scenario
An attacker could exploit the uninitialized state of the PausableUpgradeable contract to bypass pause-related checks, potentially allowing unauthorized actions to be executed when the contract is expected to be paused.

Attachments

  1. Proof of Concept (PoC) File
  1. Revised Code File (Optional)
@hats-bug-reporter hats-bug-reporter bot added the bug Something isn't working label Nov 11, 2024
@yanisepfl yanisepfl added the invalid This doesn't seem right label Nov 13, 2024
@yanisepfl
Copy link
Collaborator

Hello,
We classified this issue as invalid because:

  • It does not result in direct theft of user funds.
  • The PausableUpgradeable contract does not need to be initialized to work properly: it mainly consists of the paused state variable, which is initialized to false by default.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant