Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time lock to tokenlockfactory #114

Open
shayzluf opened this issue Mar 28, 2022 · 4 comments
Open

Add time lock to tokenlockfactory #114

shayzluf opened this issue Mar 28, 2022 · 4 comments
Labels
deployment governance version 2

Comments

@shayzluf
Copy link
Contributor

shayzluf commented Mar 28, 2022 •
edited by jellegerbrandy
Loading

On deployment, the owner of the tokenlockfactory shoul dbe a timelock.

All functions are timelocked, so we do not need a separate contract.

  • SetmasterCopy
  • Transferownership
    No timelock:
  • createTokenLock
@jellegerbrandy
Copy link
Collaborator

@shayzluf why would you want a timelock on this? What are you protecting from exactly?

@jellegerbrandy jellegerbrandy removed their assignment May 4, 2022
@shayzluf
Copy link
Contributor Author

Governance frontrunning the committee approval

@shayzluf
Copy link
Contributor Author

Governance frontrunning the committee approval

@jellegerbrandy

@jellegerbrandy
Copy link
Collaborator

good call

@jellegerbrandy jellegerbrandy mentioned this issue Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deployment governance version 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jellegerbrandy @shayzluf