Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let matchers::BuildError implement std::error::Error #7

Closed
oscargus opened this issue Aug 2, 2024 · 1 comment
Closed

Let matchers::BuildError implement std::error::Error #7

oscargus opened this issue Aug 2, 2024 · 1 comment

Comments

@oscargus
Copy link

oscargus commented Aug 2, 2024

Not sure if there is a particular reason that it doesn't? (Nor am I sure if I understand enough to grasp the consequences, no_std?, but see tokio-rs/tracing#3033 (review) for context.)

Anyway, to me it seems like this can be a good thing for more cases and may be easier than creating another error type?

@oscargus
Copy link
Author

oscargus commented Aug 2, 2024

Ah, one should probably read the code first. I now realize that it comes from regex_automata::dfa::dense, so not the correct location for the issue.

@oscargus oscargus closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant