Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segmentation_type not working needs asynchronous job for V1 API #14

Closed
pgiani opened this issue Jul 11, 2016 · 4 comments
Closed

segmentation_type not working needs asynchronous job for V1 API #14

pgiani opened this issue Jul 11, 2016 · 4 comments

Comments

@pgiani
Copy link

pgiani commented Jul 11, 2016

How to use your API to get GENDER segmentation, looking at the documentation we need to make a POST /1/stats/jobs/accounts/:account_id them get an id , them wait until the job is done them retrive the url to get the stats:
I got the info from here https://dev.twitter.com/ads/reference/1/post/stats/jobs/accounts/:account_id

From what I can see from your SDK it is adding the parameter segmentation_type and trying to retrieve the data like version 0 of the API, any plans to implement the asynchronous job for V1 of the API.

Thank you for the work on the sdk

@pgiani
Copy link
Author

pgiani commented Jul 12, 2016

I have implemented the POST stats/jobs/accounts/ for segmentation and the GET stats/jobs/accounts/ to later retrieve the JOB URL

Also added entity as a parameter in order to get the stats on the campaing level also not only lineItem level

here is my code:
https://github.com/pgiani/twitter-php-ads-sdk/blob/master/src/TwitterAds/Analytics.php

see what you think about my changes

@hborras
Copy link
Owner

hborras commented Jul 12, 2016

Hi!

Thanks, @pgiani it's a future implementation, I upgrade things when I can, now I'm solving the issue about uploading Tailored Audiences.

If you can create a Pull Request in my repo It will be easier for me to see the changes!

Thanks again!!

@pgiani
Copy link
Author

pgiani commented Jul 12, 2016

Pull request done,
#15

@hborras
Copy link
Owner

hborras commented Sep 3, 2017

Solved in e70faa3,

Working in next release

@hborras hborras closed this as completed Sep 3, 2017
@ghost ghost mentioned this issue Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants