You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, after trying it more and better understanding LocalHistory, I believe current implementation conflicts with what I'd like to achieve.
In my app, I have a button to enter "selection mode", that's because I decided to use longpress interaction for reordering items. The big difference is that selection mode is unrelated to how many items are selected.
I would like to use LocalHistory to exit selection mode, but this conflicts with current lib implementation: if I add a new entry, then the user should have to go back twice in case anything is selected, due to the entry created by this lib.
After some thinking, is it really a good idea to hide this LocalHistoryEntry in a widget? I'd suggest that it's best to handle LocalHistory at screen level, rather than in a widget that technically has nothing to do with navigation.
What about extracting this functionality in another widget that is separate from the main one? It should be quite straightforward to implement it using the selection controller.
As a note, for now I've just forked the lib and removed related code, thus I am not blocked or anything like that.
Let me know what you think, and if needed I can help with a PR :)
The text was updated successfully, but these errors were encountered:
Hi, after trying it more and better understanding LocalHistory, I believe current implementation conflicts with what I'd like to achieve.
In my app, I have a button to enter "selection mode", that's because I decided to use longpress interaction for reordering items. The big difference is that selection mode is unrelated to how many items are selected.
I would like to use LocalHistory to exit selection mode, but this conflicts with current lib implementation: if I add a new entry, then the user should have to go back twice in case anything is selected, due to the entry created by this lib.
After some thinking, is it really a good idea to hide this LocalHistoryEntry in a widget? I'd suggest that it's best to handle LocalHistory at screen level, rather than in a widget that technically has nothing to do with navigation.
What about extracting this functionality in another widget that is separate from the main one? It should be quite straightforward to implement it using the selection controller.
As a note, for now I've just forked the lib and removed related code, thus I am not blocked or anything like that.
Let me know what you think, and if needed I can help with a PR :)
The text was updated successfully, but these errors were encountered: