From cfcd12c5ae800798dd34e665d4ac5936899832aa Mon Sep 17 00:00:00 2001
From: Hoe Hao Cheng <haochengho12907@gmail.com>
Date: Mon, 25 Dec 2023 22:06:37 +0800
Subject: [PATCH] persistence: reject state files which are too new

---
 src/persistence.rs | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/persistence.rs b/src/persistence.rs
index 74b3f07..b9dd946 100644
--- a/src/persistence.rs
+++ b/src/persistence.rs
@@ -4,6 +4,11 @@ use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};
 use std::num::Wrapping;
 use std::time::{UNIX_EPOCH, SystemTime};
 
+/// The current persistent state file version. The program must reject state
+/// files newer than this, and must upgrade or reject state files older than
+/// this.
+const STATE_VERSION: u32 = 1;
+
 /// This struct stores all program states that will survive between multiple
 /// sessions. This is to prevent dynners from sending excessive update requests
 /// to the DDNS providers in scenarios like user restarting the program.
@@ -66,7 +71,7 @@ impl PersistentState {
         };
 
         Self {
-            version: 1,
+            version: STATE_VERSION,
             update_timestamp: current_timestamp,
             config_hash,
             ip_addresses: HashMap::new(),
@@ -122,6 +127,12 @@ impl PersistentState {
         // This will be a common theme in this function
         let version = <[u8; 4]>::try_from(&*version).unwrap();
 
+        // Reject newer persistence state files.
+        if u32::from_le_bytes(version) > STATE_VERSION {
+            let message = "the persistent state file is too new";
+            Err(io::Error::new(io::ErrorKind::Unsupported, message))?   
+        }
+
         let update_timestamp = read_field(&mut iter, "update timestamp", 8)?;
         let update_timestamp = <[u8; 8]>::try_from(&*update_timestamp).unwrap();