Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger builds on pull requests unless explicitly requested by committers #9

Closed
2 tasks
hcho3 opened this issue Jan 6, 2020 · 2 comments
Closed
2 tasks

Comments

@hcho3
Copy link
Owner

hcho3 commented Jan 6, 2020

See dmlc/xgboost#5176. Right now, every pull request (and edits made to them) will trigger a build in the CI server. Many pull requests are Work In Progress (WIP) and require further edits before a maintainer can merge them. To save cloud costs, no build should run on pull requests unless explicitly requested by a maintainer.

  • Write a Probot app to look for keyword "ok to test" from a maintainer. There should be a database to store the list of pull requests marked as "okay to test"
  • Modify Jenkins runner to query the database mentioned above.
@hcho3
Copy link
Owner Author

hcho3 commented Jul 13, 2020

With dmlc/xgboost#5884, it should now be easier to do this.

@hcho3
Copy link
Owner Author

hcho3 commented Sep 29, 2022

Fixed in dmlc/xgboost#8142

@hcho3 hcho3 closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant