Need to handle configoverlay.json created by Solr's ConfigAPI #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I experienced a pretty though to found bug caused by the configoverlay.json file generated when using Solr's ConfigAPI. Long story short Solr configoverlay.json unmarshalling returns a LinkedHashMap not a NamedList, which makes the [line](https://github.com/healthonnet/hon-lucene-synonyms/blob/c87fb8ced0abc9e19381a4843c964cf8473e8912/src/main/java/com/github/healthonnet/search/SynonymExpandingExtendedDismaxQParserPlugin.java#L192) always true so nothing more happen. Plus, as the unmarshalling returns a map of type Map<String, Object>, I made a really simple method to do the conversion of main types to String.
|
The part I don't like in my fix is the 'startsWith("filter")'. But I don't have much time to make it cleaner. Hope it helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced a pretty though to found bug caused by the configoverlay.json file generated when using Solr's ConfigAPI.
Long story short Solr configoverlay.json unmarshalling returns a LinkedHashMap not a NamedList, which makes the line always true so nothing more happen.
Plus, as the unmarshalling returns a map of type Map<String, Object>, I made a really simple method to do the conversion of main types to String.