Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allSatisfy description is misleading #216

Open
jayrhynas opened this issue Jul 21, 2020 · 1 comment
Open

allSatisfy description is misleading #216

jayrhynas opened this issue Jul 21, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jayrhynas
Copy link

I noticed that the section on allSatisfy says that the operator only publishes a value once the upstream publisher finishes. However, allSatisfy actually short-circuits in the same way containsWhere does, immediately publishing false and finishing once the predicate returns false.

The Apple documentation does specify this behaviour:

When this publisher receives an element, it runs the predicate against the element. If the predicate returns false, the publisher produces a false value and finishes. If the upstream publisher finishes normally, this publisher produces a true value and finishes.

@jayrhynas jayrhynas added the enhancement New feature or request label Jul 21, 2020
@heckj
Copy link
Owner

heckj commented Jul 21, 2020

Thanks @jayrhynas - I'll get it updated!

@heckj heckj self-assigned this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants