Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wayland surface resizing #58

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Conversation

trimental
Copy link
Contributor

The surface resize method must be called when resizing in order for resizing to work properly on particular platforms such as wayland.

@trimental trimental force-pushed the wayland-resizing branch 2 times, most recently from 160392c to 3175aeb Compare June 19, 2019 14:02
@hecrj
Copy link
Owner

hecrj commented Jun 19, 2019

Oh! Nice catch. Thank you!

I think we can merge the update_viewport method with this new resize one. Let me see if I can achieve that.

@hecrj
Copy link
Owner

hecrj commented Jun 19, 2019

Done! Does it still work? I have changed the order a bit, but I think it should be fine.

Thank you for this! 🎉 It simplifies the code and renames the awkward update_viewport method. resize has more intent.

@trimental
Copy link
Contributor Author

Yup, seems to work for me :)

@hecrj hecrj merged commit fa58d6a into hecrj:master Jun 19, 2019
@hecrj hecrj added this to the 0.3.0 milestone Jul 7, 2019
@hecrj hecrj modified the milestones: 0.3.0, 0.3.1 Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants