Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not refresh view of template.drawio on Mac OS X #212

Closed
john-aws opened this issue Mar 11, 2021 · 4 comments
Closed

Does not refresh view of template.drawio on Mac OS X #212

john-aws opened this issue Mar 11, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@john-aws
Copy link

New user of v1.3.0 and I have cfn-dia 1.1.20. Running on Mac OS X Mojave with VS Code 1.54.1.

I have cfn-dia running in a VS Code terminal and have opened template.drawio in VS Code. When I make a filter change using cfn-dia, e.g. to filter out Elastic IPs, cfn-dia writes a new template.drawio file (it has new timestamp and has different size) but most of the time vscode-drawio does not refresh the view of that template. It seems that only the very first change made to template.drawio is detected by vscode-drawio, but all subsequent changes are ignored.

Related: How do you get out of the cfn-dia menu?

@john-aws
Copy link
Author

john-aws commented Mar 11, 2021

Confirmed this is 100% reproducible on my Mac.

I also note that when attempting to close the drawio template view in VS Code, I am prompted "Do you want to save the changes you made to template.drawio?" I mention this in case it's relevant information. I did not make any changes using the embedded drawio editor though cfn-dia made changes to template.drawio under the covers, but I would not expect to be prompted to save something that I had not changed (within the drawio editor in VS Code).

@hediet
Copy link
Owner

hediet commented Mar 11, 2021

Yeah, I observe the same bug from time to time, however, I didn't manage to make it reproducable on windows.

Can you try out the insiders build? Afaik I changed some logic there regarding this.

@john-aws
Copy link
Author

I tried the vscode-drawio v1.4.3 insiders build (with VS Code retail build), and it had the same problems. It refreshed after the first change but not any subsequent change.

I also tried the vscode-drawio v1.4.3 insiders build (with VS Code insiders build), and it was actually more problematic. It didn't refresh after the first change or any subsequent change.

@hediet hediet added the bug Something isn't working label Mar 11, 2021
@hediet
Copy link
Owner

hediet commented Jul 11, 2021

Should be fixed by 74e0692.

Please reach out / reopen if that is not the case.

@hediet hediet closed this as completed Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants