Skip to content

Commit

Permalink
remove FirebaseJson from platfromio.ini, fix unintended change in Pow…
Browse files Browse the repository at this point in the history
…erLimiter
  • Loading branch information
Fribur committed Jan 4, 2024
1 parent d5eba23 commit bc38ce3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
1 change: 0 additions & 1 deletion platformio.ini
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ lib_deps =
https://github.com/arkhipenko/TaskScheduler#testing
https://github.com/coryjfowler/MCP_CAN_lib
plerup/EspSoftwareSerial@^8.0.1
mobizt/FirebaseJson @ ^3.0.6
rweather/Crypto@^0.4.0

extra_scripts =
Expand Down
7 changes: 4 additions & 3 deletions src/PowerLimiter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,15 @@ void PowerLimiterClass::loop()

// the normal mode of operation requires a valid
// power meter reading to calculate a power limit
if (!config.PowerMeter.Enabled) {
//instead of shutting down completelty, how about setting alternativly to a save "low production" mode?
//Could be usefull when PowerMeter fails but we know for sure house consumption will never fall below a certain limit (say 200W)
if (!config.PowerMeter.Enabled) {
shutdown(Status::PowerMeterDisabled);
return;
}

//instead of shutting down on PowerMeterTimeout, how about setting alternativly to a safe "low production" mode?
//Could be usefull when PowerMeter fails but we know for sure house consumption will never fall below a certain limit (say 200W)
if (millis() - PowerMeter.getLastPowerMeterUpdate() > (30 * 1000)) {
shutdown(Status::PowerMeterTimeout);
return;
}

Expand Down

0 comments on commit bc38ce3

Please sign in to comment.