Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics InterceptorBase uses SortedMap #1591

Closed
tomas-langer opened this issue Mar 27, 2020 · 1 comment
Closed

Metrics InterceptorBase uses SortedMap #1591

tomas-langer opened this issue Mar 27, 2020 · 1 comment
Assignees
Labels
1.x Issues for 1.x version branch 2.x Issues for 2.x version branch metrics MP P3

Comments

@tomas-langer
Copy link
Member

It seems the InterceptorBase uses SortedMap from API to get hold of a specific metric.
This should be refactored to use the registry method to get appropriate metric type,
such as MetricRegistry.counter(...) instead of MetricRegistry.getCounters(), as the first is implemented without a need for sorting all metrics every time a metric is needed.

This is a performance overhead.

@tomas-langer tomas-langer added MP metrics 1.x Issues for 1.x version branch 2.x Issues for 2.x version branch labels Mar 27, 2020
@m0mus m0mus added the P3 label Apr 2, 2020
@tjquinno
Copy link
Member

tjquinno commented Apr 2, 2020

The changes for issue #1595 addressed a couple of metrics interceptor performance issues, of which this was one. Marking this as closed.

@tjquinno tjquinno closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Issues for 1.x version branch 2.x Issues for 2.x version branch metrics MP P3
Projects
Archived in project
Development

No branches or pull requests

3 participants