Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade weld-se-core:3.1.1.final dependency of helidon 1.4.7 to latest #2650

Closed
tmb867 opened this issue Jan 12, 2021 · 5 comments
Closed

Upgrade weld-se-core:3.1.1.final dependency of helidon 1.4.7 to latest #2650

tmb867 opened this issue Jan 12, 2021 · 5 comments
Assignees
Labels

Comments

@tmb867
Copy link

tmb867 commented Jan 12, 2021

Environment Details

  • Helidon Version:1.4.7
  • Helidon MP
  • JDK version:1.8
  • OS:Windows
  • Docker version (if applicable):

Hi Team,

We are using helidon-1.4.7 in our project. The dependency weld-se-core:3.1.1.Final was showing up in the owasp scan as a low issue. When analyzing the fix for that we figured out that the dependecy 3.1.1.Final is too old.

I tried to override the version to 4.0.0, but looks like helidon is not compatible with this version. I checked the dependencies of the latest helidon version, even latest helidon uses 3.1.4.Final. I tried upgrading to 3.1.5.Final it works fine but 4.x is not supported by Helidon.

There is also a suggestion from our security lead to use weld-se-core:4.0.0.Final with helidon-1.4.7.

Can you please let us know if this can be fixed, That is provide a support for helidon-1.4.7 to work with weld-se-core:4.0.0.Final. Or if it is already planned share the timelines for the same so that we can communicate the same to our security team.

Regards,
Thammaiah MB

@barchetta
Copy link
Member

barchetta commented Jan 12, 2021

We plan on updating the dependencies in 1.4.X to more closely align with what is in 2.2.X (see #2566). So that means the first step will likely be to upgrade to 3.1.4.Final. That should address the CVE. I don't have a date for this yet, but it should be fairly soon.

We will be evaluating 4.X, but I imagine we will stay on the 3.1.X line a bit longer to give 4.X some soak time.

@dansiviter
Copy link
Contributor

dansiviter commented Jan 13, 2021

@barchetta Weld v4.x uses jakarta.* package namespace so that'll preclude it from being integrated into v1.4.x would it not? I don't think there are any functional changes in it over v3.1.x but they had to increment the major value as it's breaking.

@barchetta
Copy link
Member

@dansiviter You are correct. Weld 4.x is not an option for Helidon 1.4.x.

@barchetta
Copy link
Member

We won't be upgrading to Weld 4.x for a while due to incompatibilities with current MicroProfile specifications. For now we will be upgrading Weld to 3.1.4.Final in 1.4.8 to address the CVE (See #2566), and we will be upgrading to the latest 3.x Weld in the future. That is being tracked by issue #2665.

Since Weld upgrades are covered by #2566 and #2665 I am closing this issue.

@barchetta
Copy link
Member

barchetta commented Jan 15, 2021

@tmb867 is the owasp scan issue on weld-se-core:3.1.1.Final the one related to javascript in weld-probe-core-3.1.1.Final.jar?

If so we addressed that by excluding weld-probe-core. See #2664.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants