Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micrometer test in examples fails #3212

Closed
tomas-langer opened this issue Jul 22, 2021 · 2 comments · Fixed by #3234
Closed

Micrometer test in examples fails #3212

tomas-langer opened this issue Jul 22, 2021 · 2 comments · Fixed by #3234
Assignees
@tjquinno
Labels
bug Something isn't working examples metrics P2 testing

Comments

@tomas-langer
Copy link
Member

Follow up of #3210

The test in io.helidon.examples.micrometer.se.MainTest does not have .await() in the last section that validates Micrometer.
The #3210 will separate the tests into methods and disable it.

The original test would just hang, as the failures are not correctly propagated. The test actually fails with:

org.opentest4j.AssertionFailedError: Unable to find expected all-gets timer count 2.0 ==> 
Expected :true
Actual   :false
@tomas-langer
Copy link
Member Author

The method to fix is testMicrometer in the refactored code

@m0mus m0mus added the P2 label Jul 22, 2021
@tjquinno
Copy link
Member

Fix is ready; waiting for @tomas-langer to merge #3213

@tjquinno tjquinno mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjquinno tjquinno

Labels
bug Something isn't working examples metrics P2 testing
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix micrometer test
3 participants
@m0mus @tomas-langer @tjquinno