Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: quickstart archetype has bad k8s app.yaml and missing README instructions #4756

Closed
barchetta opened this issue Aug 19, 2022 · 1 comment
Assignees
Labels
3.x Issues for 3.x version branch archetypes bug Something isn't working P2
Milestone

Comments

@barchetta
Copy link
Member

Environment Details

  • Helidon Version: 3.0.1
  • Helidon SE

Problem Description

The 3.0.1 quickstart archetype has a bad k8s app.yaml and missing README instructions

Generate the Helidon SE Quickstart (probably MP too) using the archetype (or CLI):

mvn -U archetype:generate -DinteractiveMode=false \
    -DarchetypeGroupId=io.helidon.archetypes \
    -DarchetypeArtifactId=helidon-quickstart-se \
    -DarchetypeVersion=3.0.1 \
    -DgroupId=io.helidon.examples \
    -DartifactId=helidon-quickstart-se \
    -Dpackage=io.helidon.examples.quickstart.se

Inspect app.yaml. You'll see it only has the Service section and not Deployment. If you apply this app.yaml you'll only get a service with no pods.

Also, there is no Kubernetes information in the README. To see how this should work do the above but replace "3.0.1" with "2.5.2"

@barchetta barchetta added bug Something isn't working examples 3.x Issues for 3.x version branch labels Aug 19, 2022
@barchetta barchetta added this to the 3.0.2 milestone Aug 19, 2022
@barchetta
Copy link
Member Author

Workaround: Use app.yaml from 2.x:

kind: Service
apiVersion: v1
metadata:
  name: helidon-quickstart-se
  labels:
    app: helidon-quickstart-se
spec:
  type: NodePort
  selector:
    app: helidon-quickstart-se
  ports:
  - port: 8080
    targetPort: 8080
    name: http
---
kind: Deployment
apiVersion: apps/v1
metadata:
  name: helidon-quickstart-se
spec:
  replicas: 1
  selector:
    matchLabels:
      app: helidon-quickstart-se
  template:
    metadata:
      labels:
        app: helidon-quickstart-se
        version: v1
    spec:
      containers:
      - name: helidon-quickstart-se
        image: helidon-quickstart-se
        imagePullPolicy: IfNotPresent
        ports:
        - containerPort: 8080
---

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch archetypes bug Something isn't working P2
Projects
Archived in project
Development

No branches or pull requests

2 participants