Copied config node uses unescaped key if the key contains a dot

[tjquinno]

Environment Details

• Helidon Version: 4.x
• Helidon SE or Helidon MP
• JDK version:
• OS:
• Docker version (if applicable):

---

Problem Description

When a config node is copied, if the key contains a dot the copied key is not escaped so the resulting copy has the wrong key.

Steps to reproduce

Add the following test to ConfigCopyTest and run it. It fails because the copied key is not escaped when the new copy of the node is created:

   @Test
    void testDottedKey() {
        var withDottedName = ConfigNode.ObjectNode.builder()
                .addValue(Config.Key.escapeName("first.one"), "firstValue")
                .addValue("second", "secondValue")
                .build();

        var rootNode = ConfigNode.ObjectNode.builder()
                .addObject("object", withDottedName)
                .build();

        var originalConfig = Config.builder()
                .disableSystemPropertiesSource()
                .disableEnvironmentVariablesSource()
                .addSource(io.helidon.config.ConfigSources.create(rootNode))
                .build();

        assertThat("Dotted name entry in original",
                   originalConfig.get("object." + Config.Key.escapeName("first.one")).asString().get(),
                   is("firstValue"));

        var copyConfig = Config.builder()
                .disableSystemPropertiesSource()
                .disableEnvironmentVariablesSource()
                .addSource(ConfigSources.create(originalConfig))
                .build();

        var firstOneConfigValue = copyConfig.get("object." + Config.Key.escapeName("first.one")).asString();
        assertThat("Dotted name key in copy is present",
                   firstOneConfigValue.isPresent(),
                   is(true));
        assertThat("Dotted name value in copy",
                   firstOneConfigValue.get(),
                   is("firstValue"));
    }

[danielkec]

Same test seems to be failing in 3.x too

[tjquinno]

Yes. I've created backport issues.