-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x] Missing Http Status codes for 421...429,431,451 #7343
Comments
I am not for including every code listed - the codes we have in Helidon are part of specifications. It would be nice to have a clear understanding which RFC defines that status code. |
A reasonable list of status codes: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/451 |
FWIW I'm fine with not adding them all. The missing codes I expect to use myself and would really love to see added are
With these 3 added (plus maybe 428?) I'd be content. FYI: Background motivation: Edit: |
Reference links that might help via https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml with the status codes and related RFC |
I have added the requested statuses, PR is ready. |
Environment Details
Problem Description
io.helidon.common.http.Http.Status
has public static fields for the Http status codes. In the400
range it stops at418
and the status codes for421, 422, 423 ... 429, 431, 451
are missing.Refer: https://github.com/helidon-io/helidon/blob/main/common/http/src/main/java/io/helidon/common/http/Http.java#L551
Suggested fix
Add entries in https://github.com/helidon-io/helidon/blob/main/common/http/src/main/java/io/helidon/common/http/Http.java for the status codes:
421, 422, 423 ... 429, 431, 451
The text was updated successfully, but these errors were encountered: