Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide mechanism to disable all or selected metrics #958

Closed
markxnelson opened this issue Aug 26, 2019 · 3 comments
Closed

Provide mechanism to disable all or selected metrics #958

markxnelson opened this issue Aug 26, 2019 · 3 comments

Comments

@markxnelson
Copy link
Contributor

Environment Details

  • Helidon Version: 1.2.1
  • Helidon MP
  • JDK version: 11
  • OS: linux
  • Docker version (if applicable): 19

Problem Description

I can disable individual metrics like this:
metrics.base.classloader.currentLoadedClass.count.enabled=false

But I cannot disable all metrics, I would like to be able to do something like one of these…
metrics.base.*.enabled=false
metrics.base.all.enabled=false
metrics.base.enabled=false

@markxnelson
Copy link
Contributor Author

@tomas-langer @pfmackin FYI

@tomas-langer
Copy link
Member

tomas-langer commented Sep 9, 2019

See #990 - solution for Health for overall disabling of the feature

@tjquinno tjquinno changed the title Provide mechanism to disable all metrics Provide mechanism to disable all or selected metrics Sep 9, 2019
@tjquinno tjquinno self-assigned this Sep 24, 2019
@tjquinno
Copy link
Member

tjquinno commented Sep 24, 2019

See PR #1052

Note that the proposed changes allow you to control base metrics using the third of your suggestions: metrics.base.enabled=false.

This:

  • is consistent with other (e.g., health) component-wide config settings,
  • does not collide with any current or potentially future base metric, and
  • does not introduce new semantics (helpful though they might be) for wildcarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants